Fix race condition when trying to connect twice at the same time with the websockets transport #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leszekhanusz
added a commit
to leszekhanusz/gql
that referenced
this pull request
Jul 5, 2020
Co-authored-by: Manuel Bojato <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connecting twice with the same client is not allowed and should raise
TransportAlreadyConnectedthe second time.Because of a bug in the websockets transport, if the user tries to connect twice at the same time (in different tasks), it will raise a RuntimeError (
RuntimeError: cannot call recv while another coroutine is already waiting for the next message)This PR will fix this bug which was reported in issue #105